search

perliedman / ocad2geojson

JavaScript OCAD file reader and exporter for GeoJSON, SVG and Mapbox Style Spec
https://www.liedman.net/ocad2geojson/
GNU Affero General Public License v3.0
39 stars 4 forks source link

Coursesetting #19

Closed pauliojanpera closed 2 years ago

pauliojanpera commented 3 years ago

Hi!

Your project gave me a kick start to implementing some of my ideas. Thank you a lot. =)=)=)

I am working to view Ocad courses in SVG. I fixed some bugs in the code and switched the text label renderer to use HTML div's. I do not know if you consider that a good approach because it will limit the SVG viewers to those which can view HTML too. Div's provide us multiline rendering for free, though. One possibility would be to render only the multiline texts as divs..

Anyway, there are no brainer bugfixes included.

perliedman commented 3 years ago

Hi, thanks for this. it looks like there are quite a few changes in the same PR here, I will try to have a look soon, although I'm currently on vacation so can't promise exactly when.

As a side note, I'm working on a similar project called O-Scout, although it can currently only read Purple Pen courses. At this moment SVG/PDF is broken, but it's very close to working. Maybe I can get it to read OCAD courses as well with your PR!

pauliojanpera commented 3 years ago

I understand if you do not wish to have the HTML dependency on the SVG output. That can be left out. However, I think I'm going to proceed implementing course setting features based on HTML+CSS because my target will be the browser platform anyway. Maybe that could be a command line option or an entirely separate export format?

perliedman commented 3 years ago

Yes, an option sounds reasonable as long as the pure SVG output has limitations on text!

perliedman commented 3 years ago

If you could make the HTML changes optional, or split that part into a separate PR, I'd be happy to merge this!