Closed perlindgren closed 1 year ago
Problem:
As of now SignalData denotes the values of signal. However, usage is inconsistent, in cases setters use the naming value or val.
SignalData
value
val
Solution: A small re-factor of SignalData into SignalValue and consitent usage value for setters/getters.
SignalValue
This is a simple syntactic change and should improve overall readability, PR in https://github.com/perlindgren/syncrim/pull/48.
Close as merged.
perlindgren
commented
1 year ago perlindgren
commented
1 year ago
Problem:
As of now
SignalDatadenotes the values of signal. However, usage is inconsistent, in cases setters use the namingvalueorval.Solution: A small re-factor of
SignalDataintoSignalValueand consitent usagevaluefor setters/getters.This is a simple syntactic change and should improve overall readability, PR in https://github.com/perlindgren/syncrim/pull/48.