search

perlorg / cnntp

www.nntp.perl.org site
5 stars 4 forks source link

Show "A message" when a messages title is invisible #5

Closed guest20 closed 1 year ago

guest20 commented 1 year ago

If some absolute madlad sends a reply to a list with no printable characters in the message subject the link to read the message is invisible and so quite difficult to click.

"A message by authorname" seems like a reasonable stand-in

Without this patch (or one like it) one must open the inspector to click the link to the message from redacted:

Screen Shot 2023-06-23 at 12 33 10
guest20 commented 1 year ago

@abh I don't see a CONTRIBUTING thing, so I'm just gonna at the last person who committed on main and hope for the best

abh commented 1 year ago

thanks @guest20

abh commented 1 year ago

Deployed and looks good; thanks!

https://www.nntp.perl.org/group/perl.perl5.porters/2023/06/msg266489.html

Screenshot 2023-06-23 at 19 30 57
abh commented 1 year ago

If you want to give a try at why those subjects don't decode, that'd be nice to have fixed, too. :-)

guest20 commented 1 year ago

The message referenced them being away from their usual laptop, so I assumed it was a janky webmail that just sent a blank subject line ...

It would be less of a guess if there was a "show raw message source" option, but that might be overkill for investigating a tiny bug like this

Also, looking at your screen shot, it feels kinda bad that "A message" isn't in italics or marked in some way to communicate that it's not jut a message with Subject: A message. I don't think it's a huge vulnerability though.

abh commented 1 year ago

@guest20 The "backing store" for all this is NNTP on nntp://nntp.perl.org/

I put a copy of this particular article here: https://tmp.askask.com/os/tmp/colobus-subject.eml