perlpunk / App-Spec-p5

Writing command line apps made easy
Other
23 stars 9 forks source link

defaulting _complete to the shell of the parent process #10

Closed EitanSchuler closed 8 years ago

EitanSchuler commented 8 years ago

I have no idea if this is something you want, but it was a low-hanging fruit.

perlpunk commented 8 years ago

Thanks! merged and added an extra check of the ps output

perlpunk commented 8 years ago

Just a recommendation, because I also made this mistake for my first pull request(s), and I see also other people doing this: Always create a topic branch for pull requests, because:

EitanSchuler commented 8 years ago

Thanks, perlpunk, will do so in the future.

perlpunk commented 8 years ago

I found a bug: ps might return, for example: -zsh, /bin/bash, ...