Inconsistent Tags

[elliotsayes]

Key and Value are both different here, not sure which is correct

https://github.com/permaweb/vouch-x/blob/06cb364dec860620e74ff49ea0e9ae839bb19f90/server/lib/is-vouched.js#L11 https://github.com/permaweb/vouch-x/blob/06cb364dec860620e74ff49ea0e9ae839bb19f90/server/lib/dispatch.js#L16

[twilson63]

Dispatch is legacy Vouch Version is-vouched is using new vouch schema

@.***/r13cgYWlC?type=view

On Sun, Aug 18, 2024 at 1:46 AM elliotsayes @.***> wrote:

Key and Value are both different here, not sure which is correct

https://github.com/permaweb/vouch-x/blob/06cb364dec860620e74ff49ea0e9ae839bb19f90/server/lib/is-vouched.js#L11

https://github.com/permaweb/vouch-x/blob/06cb364dec860620e74ff49ea0e9ae839bb19f90/server/lib/dispatch.js#L16

— Reply to this email directly, view it on GitHub https://github.com/permaweb/vouch-x/issues/7, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAFGLATAQJ7CFJA5BYM7WTZSAYKRAVCNFSM6AAAAABMWBUQX2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGQ3TCNZZHE4TOMA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

[elliotsayes]

Thanks! I'll see if I can support all 👍

[elliotsayes]

Wait-- are these supposed to be the same then? It seems like the format in is-vouched doesn't match up with any of them https://github.com/permaweb/vouch-x/blob/06cb364dec860620e74ff49ea0e9ae839bb19f90/server/lib/is-vouched.js#L9 https://github.com/permaweb/vouch-x/blob/06cb364dec860620e74ff49ea0e9ae839bb19f90/server/lib/send-message.js#L11

[twilson63]

Yep, that is a bug in is-vouched it should be { name: 'Data-Protocol', values: ['Vouch'] },

according to the spec

[elliotsayes]

Cool thanks!