search

permissions-dispatcher / PermissionsDispatcher

A declarative API to handle Android runtime permissions.
https://github.com/permissions-dispatcher/PermissionsDispatcher
Apache License 2.0
11.23k stars 1.44k forks source link

[Proposal]Drop Xiaomi support? #544

Closed hotchemi closed 5 years ago

hotchemi commented 5 years ago

to @permissions-dispatcher/maintainers and users

Overview

We've been suffering from Xiaomi issues in a past few years. There's no official document, reference and seems like they've changed permission related behavior without any announcementđŸ¤”

And according to https://github.com/permissions-dispatcher/PermissionsDispatcher/issues/533#issuecomment-438170843 the latest MIUI has a system that automatically handles permission dialog on system sideđŸ‘€Not it's a good time to drop Xiaomi handling code from our library? What do you think?

From my point of view:

Props

Cons

shiraji commented 5 years ago

Developers who have to handle newest MIUI system should get the same result with us. I wonder how they fix the problem...

hotchemi commented 5 years ago

done đŸ˜‡

hotchemi commented 5 years ago

@wangxinghe do you have any insights(sorry to mention you suddenly since I've just seen you gave a star to the library:D)? đŸ™‡