permissions-dispatcher / PermissionsDispatcher

A declarative API to handle Android runtime permissions.
https://github.com/permissions-dispatcher/PermissionsDispatcher
Apache License 2.0
11.22k stars 1.44k forks source link

compile time validation for detecting OnNeverAskAgain with special permissions #549

Closed hotchemi closed 5 years ago

hotchemi commented 5 years ago

Issue

resolves https://github.com/permissions-dispatcher/PermissionsDispatcher/issues/436

Overview

This PR adds compile time validation for detecting OnNeverAskAgain declaration with 'WRITE_SETTINGS' or 'SYSTEM_ALERT_WINDOW' to address https://github.com/permissions-dispatcher/PermissionsDispatcher/issues/436.

hotchemi commented 5 years ago

Btw I've found there're some O(N2) time complex codes in validation..🤔We can speed up more by fixing that! Let me merge for now.