OnShowRationale API change with keeping backward compatibilty - Githubissues

permissions-dispatcher / PermissionsDispatcher

A declarative API to handle Android runtime permissions.

https://github.com/permissions-dispatcher/PermissionsDispatcher

Apache License 2.0

11.22k stars 1.44k forks source link

OnShowRationale API change with keeping backward compatibilty #569

Closed hotchemi closed 5 years ago

hotchemi commented 5 years ago

Issue

resolves https://github.com/permissions-dispatcher/PermissionsDispatcher/issues/434

Overview

As discussed at https://github.com/permissions-dispatcher/PermissionsDispatcher/pull/562#issuecomment-448569389, processor generates process${NeedsPermissionMethodName}ProcessRequest and cancel${NeedsPermissionMethodName}ProcessRequest methods only when user defines OnShowRationale annotated method with no parameter!

ref: https://github.com/permissions-dispatcher/PermissionsDispatcher/pull/562

hotchemi commented 5 years ago

Let me merge!