Do not call requestPermissions if permission was already denied permanently

[WonderCsabo]

Overview

The library ask for permissions even if the user permanently denied it before (checked "Do not ask again"). This adds an unnecessary call, and also notifies the app about a user action which is not happening (the permission dialog is not shown actually).

Expected

If we detekt the user already denied the permission with never ask again, we should not call requestPermissions().

Actual

Currently we always call requestPermissions(), regardless the user denied it permanetly before or not.

Pseudo solution

fun WelcomeScreenFragment.welcomeButtonClickedWithPermissionCheck() {
    if (PermissionUtils.hasSelfPermissions(this.requireActivity(),
                    *PERMISSION_WELCOMEBUTTONCLICKED)) {
        welcomeButtonClicked()
    } else {
        if (PermissionUtils.shouldShowRequestPermissionRationale(this,
                        *PERMISSION_WELCOMEBUTTONCLICKED)) {
            this.requestPermissions(PERMISSION_WELCOMEBUTTONCLICKED, REQUEST_WELCOMEBUTTONCLICKED)
        }
    }
}

[hotchemi]

Thank you for your suggestion and that makes a lot of sense! Would you mind open a PR? 👀

[WonderCsabo]

I try to find the time to do it!

[isabsent]

Does this issue exist for Kotlin only or Java is suffered to it too?

[WonderCsabo]

I experienced it using Java. I think this issue is language independent.

[kaushalyap]

actually if permission is denied permanently, app should allow user to go to settings and rectify it, since it is good UX

[hotchemi]

let us close the issue as:

• AFAIK there's no API that we can get the result without onRequestPermissionsResult(and it's deprecated)
• it's been a long since the issue was opened.

we're still welcome for PR.