Fix Conductor tests - Githubissues

permissions-dispatcher / PermissionsDispatcher

A declarative API to handle Android runtime permissions.

https://github.com/permissions-dispatcher/PermissionsDispatcher

Apache License 2.0

11.22k stars 1.44k forks source link

Fix Conductor tests #608

Closed technoir42 closed 5 years ago

technoir42 commented 5 years ago

Fixes:

org.mockito.exceptions.misusing.InvalidUseOfMatchersException: 
Misplaced argument matcher detected here:

-> at permissions.dispatcher.test.ExtensionsKt.mockShouldShowRequestPermissionRationaleConductorController(Extensions.kt:83)

You cannot use argument matchers outside of verification or stubbing.

hotchemi commented 5 years ago

@technoir42 Hi I'm really sorry for being late🙇Can I ask why this change is needed? I thought we don't need this since CI basically passes on TravisCI? let me kn ow if I'm missing 🙇

technoir42 commented 5 years ago

These tests fail locally when I run ./gradlew clean test on master and also fail from IDE. It's weird that they pass on TravisCI.

Can you try running them locally in both ways?