search

permitio / fastapi_websocket_rpc

⚡ FASTAPI Websocket RPC- A fast and durable bidirectional JSON RPC channel over Websockets.
https://permit.io
MIT License
188 stars 19 forks source link

No Await Expression for Websocket Closing #36

Open wes8ty opened 2 months ago

wes8ty commented 2 months ago

Was testing this library out and the following line self._websocket.close(code) needs an await

async def close(self, code: int = 1000):
    if self._websocket is not None:
        # Case opened, we have something to close.
        self._websocket.close(code)
orweis commented 2 months ago

Want to open a PR? :)