permitio / opal-helm-chart

You know, for Kubernetes
Apache License 2.0
21 stars 22 forks source link

Chart do not permit use of specific docker credentials #5

Closed bgiarrizzo closed 2 years ago

bgiarrizzo commented 2 years ago

The server and client templates does not permit the use of specific docker credentials.

It should embark this directive :

imagePullSecrets:
  - name: name_of_my_dockercreds

I am preparing a PR regarding this issue, will push it tomorrow.

asafc commented 2 years ago

Hi @bgiarrizzo :) We really appreciate your willingness to contribute :) cc me when you are done, and i'll review your PR :)

bgiarrizzo commented 2 years ago

Hello @asafc, thank you for your reply.

I pushed my modification this afternoon, you can see the work in #7 .