Closed beejsbj closed 4 months ago
We need to be able to see what these things are at a glance
Even "Tune up typography styles" - or "Adjust type patterns" or "Assess global type rules" is 10x beetter.
And the tone of. "using... " "adding...." - is very passive and takes more work to understand.
What voice did you add? Why?
"Add microcopy voice to fill the need for form labels and figure captions" (this should also probably just be its own PR / and probably should be discussed even before a PR. "Hey, guys - what about this idea" - etc...
Bigger projects might put this all in one PR / but this is a very small set of style rules --
things like --font1 and --step-6 aren't very intuitive to me
things like --body-font - and --display-font font are.
Hmm, i see your point, but i figured that these fonts would just be used to build out the text-voices anyway. (which would then be used across the site having more intuitive names). Same case for the steps, you'd wouldn't want to use them outside of building the text voices. (unless you need to use a more drastic shift at a breakpoint)
So, those variables don't really get used outside of the typography sheet.
My understanding of pssst-css is for it to be like a baseline reset with some neat ideas for most standard websites (stuff like inner-column already push towards that idea), so I wasn't really thinking about other mediums like newspapers or posters.
I personally think the steps using clamps in that way is a generally a better design pattern than using breakpoints especially for most standard sites. (plus people get to see the power of clamp :D)
Let's revisit this in person - with examples.