search

perpetualKid / GetText.NET

A .NET Standard cross-platform implementation of GNU Gettext
Other
34 stars 11 forks source link

Bug (?) with aliases requiring member syntax #40

Closed Owlblocks closed 2 years ago

Owlblocks commented 2 years ago

I feel really bad for not catching this sooner, but it appears that the recent changes have a caveat. While they do work, generally, the original goal of support for _() isn't exactly met, as currently custom aliases only work if they are in a member-access syntax, e.g. ClassName.(). This means that, say, a global static using directive wouldn't allow the programmer to extract from a method that is simply called via ().

I should be able to fix this when I have time today or maybe tomorrow, assuming it wouldn't break the code more generally.

Owlblocks commented 2 years ago

Any idea when a build will be published to Nuget? Or if there's a means of installing a Nuget Package from source?

perpetualKid commented 2 years ago

Any idea when a build will be published to Nuget? Or if there's a means of installing a Nuget Package from source?

sorry I forgot to trigger the publish workflow, done now and new version 1.6.6 is available on Nuget https://www.nuget.org/packages/GetText.NET.Extractor/1.6.6

Thanks for update and implementation, would appreciate if the wiki gets updated as well to describe the new command line options and behavior regarding static/non-member syntax https://github.com/perpetualKid/GetText.NET/wiki/Extractor-CLI