Extractor wrongly extracts interpolated strings with strings inside of them

[pontaoski]

Example:

GetString($"{Specifier}login {"username".Color(Utils.GreenHighlight)} {"password".Color(Utils.BoldHighlight)} - Logs in using your username and password.")

gets extracted as

{0}login {1} {2} - Logs in using your username and password.usernamepassword

rather than

{0}login {1} {2} - Logs in using your username and password.

[perpetualKid]

Extractor does not handle expressions as part of interpolated string parameter, which is also mentioned in the docs, and the general recommendation and workaround in your case would be to

string username = "username".Color(Utils.GreenHighlight);
string password = "password".Color(Utils.BoldHighlight);
GetString($"{Specifier}login {username} {password} - Logs in using your username and password.")

However I do agree that handling of string parameters could be improved for some cases.

[perpetualKid]

update now handles cases like

    internal class Program
    {
        static void Main(string[] args)
        {
            Catalog catalog = CatalogManager.Catalog;
            string Specifier = "Specifier";
            catalog.GetString($"{Specifier}login {"username".Color(Color.White)} {"password".Color(Color.Green)} - Logs in using your username and password.");
            catalog.GetString($"some {"strange"} text");
            catalog.GetString($"some {catalog.GetString("strange")} text");
        }
    }

    static class StringExtension
    {
        public static string Color(this string value, Color color)
        {
            return value;
        }
    }

, csharp-format

msgid "some {0} text" msgstr ""

msgid "{0}login {1} {2} - Logs in using your username and password." msgstr ""

msgid "strange" msgstr ""

Probably incorporating some other updates next couple days before releasing a new version.

[perpetualKid]

closing as of 1.7.14