Open boyanpenkov opened 2 weeks ago
Without looking in detail, the items can be stored as name.pdf , or as name/original_name.pdf, to allow for attachments to be saved alongside (it's quite, but not entirely PDF-centric).
...and the checksum function can only apply to a PDF, not to a directory
@perrette -- Ok, ready for your perspective... with a significant caveat:
The actual feature works, and the test to check is test_add_rename_copy_journal()
in test_add.py
. This passes, and manually inspecting the behavior on a few files passes as well, so that's nice.
The bad thing is that the test suite runs papers
directly, and so depends on the config the user has specified (which, in my case for for testing this, does have {journal}
and so breaks the temp files that are written.) This breaks a lot of the undo-redo tests; all breakages there have been marked TODO and I know what they are.
What might get around this is generating an --ignore-install
option, for papers
to simply not read the install config and run with the consistent defaults. Alternately, are you familiar with https://docs.pytest.org/en/6.2.x/fixture.html ? Couching the tests in terms of these might be a more robust long-term solution, but is a re-work of more major sorts.
So, I think I need an opinion from the papers BDFL here. ;)
@perrette -- just touching base here...
Hello, just wanted to touch base here....
wip
dontmerge
closes https://github.com/perrette/papers/issues/64
I am looking at adding the {journal} option here, and thing I have tracked though the entry mechanism there. however, when I run, I see the following error still:
@perrette -- am I missing something here? That thing is indeed a directory, which is the target for the PDFs I'd like to have.
I will end up testing this in
test_add.py
unless there are objections.