search

perrycate / tournamap

Website to visualize Smash Ultimate tournaments near you
https://tournamap.gg
GNU General Public License v3.0
9 stars 6 forks source link

added css reset to start from a base style across different browsers… #27

Closed schneedotdev closed 2 years ago

schneedotdev commented 2 years ago

I added a folder for CSS files, and organized the link tags in your html. I also saw in your CSS you had used the all selector and added some base styles like (margin: 0; and padding: 0). I think it could be valuable to use a file like "reset.css" which creates a baseline for all future styles across browsers. If you plan to merge this, realize that you will have to then style from that baseline, where as in your current state of the app, you are utilizing the default stylings of all the tags such as the h1 text appearing larger than an h2 for example. I can add additional styling in the future to resolve this. For future pull requests, I will make a separate branch.

schneedotdev commented 2 years ago

Thank you for checking out my pull request. I have went ahead and made the changes, let me know if you would like anything further.

perrycate commented 2 years ago

Good work, thanks!