perryhuynh / kcauto

kcauto, the successor to kancolle-auto, a Kantai Collection (Kancolle) bot/automation tool
GNU General Public License v3.0
68 stars 22 forks source link

[Event] 2019 Fall Event Support #390

Open mrmin123 opened 4 years ago

mrmin123 commented 4 years ago
mrmin123 commented 4 years ago

390-2019-fall-event; preliminary data courtesy of @perryhuynh

mrmin123 commented 4 years ago

Pushed a number of changes to the event branch that should fix navigation to the event maps.

mrmin123 commented 4 years ago

Event branch has been updated multiple times with fixes and updates to both panel and json asset updates. Additional changes:

tsuki-tsuki commented 4 years ago

Node recognition sometimes missed when using v8. Is this known issue?

Also can night battle settings use old mode (battle num.) from GUI? When manually edit the config file, kcauto can read it as expected, but there's no option to add using battle num. from GUI.

Overall, loving this new implementation. Still not as stable as the old one, but consumes less CPU than before. Keep up the good job!

mrmin123 commented 4 years ago

@tsuki-tsuki the inability to specify node by count for night battles is a bug. I'll fix that eventually, but for now please modify the config manually. Apologies for the inconvenience.

As for the node recognition, I'm not sure what you mean by this? Are you saying that sometimes kcauto doesn't understand that it arrived at a new node? aka gets stuck in a loop before choosing a formation?

And thanks, glad you like the new version!

tsuki-tsuki commented 4 years ago

Either stuck in formation select, or it mistakes current node as another node. I'll try to see if that happens again, and post the log later.

Also sometimes expedition module also stuck at In expedition status even when the fleet has returned and expected return time has passed.

On Dec 11, 2019, at 3:41 AM, Minyoung Choi notifications@github.com wrote:

 @tsuki-tsuki the inability to specify node by count for night battles is a bug. I'll fix that eventually, but for now please modify the config manually. Apologies for the inconvenience.

As for the node recognition, I'm not sure what you mean by this? Are you saying that sometimes kcauto doesn't understand that it arrived at a new node? aka gets stuck in a loop before choosing a formation?

And thanks, glad you like the new version!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

tsuki-tsuki commented 4 years ago

Here's the expedition log. Should I just open an issue?

Expedition stuck log [2019-12-12 01:30:21] kcauto has been running for 0d 3h 16m 48s (loop 51). [2019-12-12 01:30:21] Next sortie at 2019-12-11 23:15:19 / 5 sorties (1.52/hr) / 20 nodes fought (6.10/hr) / 3 ships rescued (0.91/hr) / 1 (0.30/hr) [2019-12-12 01:30:21] 1 Expeditions sent (0.30/hr) / 5 Expeditions received (1.52/hr) [2019-12-12 01:30:21] Fleet 1 / Minor fleet damage / No Fatigue [2019-12-12 01:30:21] Fleet 2 / Minor fleet damage / No Fatigue [2019-12-12 01:30:21] Fleet 3 / On expedition / Returning at 2019-12-12 01:02:10 [2019-12-12 01:30:21] Fleet 4 / On expedition / Returning at 2019-12-11 23:41:37 ---redacted--- [2019-12-12 01:30:41] Fleets 3 and 4 have returned!

It looks like expedition return is detected, but next expedition is never sent.

mrmin123 commented 4 years ago

@tsuki-tsuki yea, open another issue please to track the issue. Please also include the config file. How did kcauto send only 1 expedition but receive 5? Did you manually send expeditions?

Also, you should now be able to specify night battles by node number in the GUI.