perryhuynh / kcauto

kcauto, the successor to kancolle-auto, a Kantai Collection (Kancolle) bot/automation tool
GNU General Public License v3.0
68 stars 23 forks source link

[Housekeeping] Additional docs #391

Open mrmin123 opened 4 years ago

mrmin123 commented 4 years ago

Many classes and methods are still missing in-line documentation. Fill these out before I forget...

ForsakenRei commented 4 years ago

Maybe off topic but can 8.0 run with game browser like 74EO (https://github.com/andanteyk/ElectronicObserver)? It's based on cefsharp (http://cefsharp.github.io/) so it should be a Chromium based browser?

mrmin123 commented 4 years ago

@ForsakenRei I've not tested this but it theoretically is possible! As long as the Chromium-based app can run with the remote debugging port open (and pyChromeDevTools can hook into it), it should be possible.

ForsakenRei commented 4 years ago

Thanks. There is a way to set a port that can be listened by other app but I suppose it is different from the remove debugging port...? I will try it out.