search

perryhuynh / kcauto

kcauto, the successor to kancolle-auto, a Kantai Collection (Kancolle) bot/automation tool
GNU General Public License v3.0
68 stars 23 forks source link

Support expeditions being sent after combat module is disabled #408

Closed perryhuynh closed 4 years ago

perryhuynh commented 4 years ago

Environment details

Issue variability

Is the issue consistent (can be reproduced consistently) or is it intermittent (only happens sometimes)?: Consistent

Issue

Support expeditions should no longer be sent after the combat module is disabled

Log

[2019-12-04 16:31:53] kcauto has been running for 0d 0h 15m 39s (loop 1).
[2019-12-04 16:31:53] Combat module disabled as of 2019-12-04 16:30:26 / 1 sorties (1.00/hr) / 5 nodes fought (5.00/hr) / 2 ships rescued (2.00/hr)
[2019-12-04 16:31:53] 1 Expeditions sent (1.00/hr) / 0 Expeditions received (0.00/hr)
[2019-12-04 16:31:53] Fleet 1 / No Damage fleet damage / No Fatigue
[2019-12-04 16:31:53] Fleet 2 / Scratch fleet damage / No Fatigue
[2019-12-04 16:31:53] Fleet 3 / At base
[2019-12-04 16:31:53] 3 resupplies done (3.00/hr) / 0 provisional resupplies done (0.00/hr)
[2019-12-04 16:31:53] 4 repairs done (4.00/hr) / 4 buckets used (4.00/hr)
[2019-12-04 16:31:53] Active Scheduler rules:
[2019-12-04 16:31:53] Fuel:280072 (Δ-708 : -708.00/hr) / Ammo:293452 (Δ-839 : -839.00/hr) / Steel:297456 (Δ-87 : -87.00/hr) / Bauxite:298115 (Δ-95 : -95.00/hr) / Bucket:2831 (Δ-4 : -4.00/hr)
[2019-12-04 16:32:14] Fleet 3 ready for expedition.
[2019-12-04 16:32:17] At home
[2019-12-04 16:32:17] Navigating to expedition screen.
[2019-12-04 16:32:24] Sending fleet 3 to expedition S2.
[2019-12-04 16:32:34] Fleet 3 is away on assignment.
[2019-12-04 16:32:34] Fleet 3 returns at 2019-12-04 17:02:34.
mrmin123 commented 4 years ago

The should_and_able_to_sortie method was capable of returning True even when the combat module was disabled. This has been corrected in the 390-2019-fall-event branch.