Verifying LBAS resupply

stackhanovets commented 4 years ago

Please make sure you are on the latest version of kcauto, and that there is not already a ticket open for your issue.

Please remove sections of this template you do not find relevant when creating your ticket.

Environment details

kcauto version (version on first line of CHANGELOG.md): v8.0.0-rc1
Operating system and/or VM: Win7 x64 MSDN SP1

Issue variability

Is the issue consistent (can be reproduced consistently) or is it intermittent (only happens sometimes)?

Intermittent yet applicable even for previous versions.

Issue

Please provide a thorough description of the issue. Screenshots, videos, or at least a step-by-step description of what is happening in the game is typically necessary to debug.

Some of LBAS squadrons fail to resupply from time to time finally resulting to chevron loss and bauxite shortage;
An obvious part is successful OCR assessment but miss-click to a non-related zone;
Non-obvious part is the rendering peculiarity of the LBAS resupply button: the {cursor: text} zone may have priority over the {cursor: pointer} zone, being virtually on top:

layout

The failure facts were successfully detected by KC3Kai, so they are definitely accessible via API. I suppose, the solution is loop the resupply process until the positive API response.

Log

[insert ~50 lines of console log (or more) here; remove section if irrelevant]
Nothing special to report here.

Config

[insert relevant config sections here; remove section if irrelevant]
  "combat.lbas_groups": [
    1,
    2
  ],
  "combat.lbas_group_1_nodes": [
    "M",
    "M"
  ],
  "combat.lbas_group_2_nodes": [
    "M",
    "M"
  ],
  "combat.lbas_group_3_nodes": [],
  "combat.check_fatigue": true,
  "combat.check_lbas_fatigue": true,

mrmin123 commented 4 years ago

@stackhanovets I've pushed some code to the event branch that makes the fleet and LBAS resupply actions dependent on API responses. Please give this a shot to see if it's more reliable.

stackhanovets commented 4 years ago

After a short test I found that the first LBAS fails to resupply sporadically...

[94m[DATE TIME] At home[0m
[94m[DATE TIME] Navigating to combat screen.[0m
[DATE TIME] Begin waiting for API payload(s).
[DATE TIME] Waiting for request REQUEST_NUM (http://GAME_SERVER/kcsapi/api_get_member/mapinfo)
[DATE TIME] Request REQUEST_NUM received
[DATE TIME] Updating Combat map data from API.
[DATE TIME] Updating LBAS group data from API.
[94m[DATE TIME] Managing LBAS groups.[0m
[94m[DATE TIME] Switching LBAS state from Standby to Sortie.[0m
[DATE TIME] Switching LBAS state from Standby to Sortie.
[DATE TIME] Begin waiting for API payload(s).

< ~1 min passed, nothing happened >

[94m[DATE TIME] Resupplying LBAS group 2.[0m
[DATE TIME] Begin waiting for API payload(s).
[DATE TIME] Begin waiting for API payload(s).
[DATE TIME] Begin waiting for API payload(s).
[DATE TIME] Waiting for request REQUEST_NUM (http://GAME_SERVER/kcsapi/api_req_air_corps/supply)
[DATE TIME] Request REQUEST_NUM received

< LBAS 2 was resupplied >

mrmin123 commented 4 years ago

That looks like it's from the LBAS state changes acting funky (which I've noticed recently), not the resupply action.

stackhanovets commented 4 years ago

LBAS #1 has not been resupplied definitely.

mrmin123 commented 4 years ago

hmm I'll have to check the logic again. It looks like it didn't even try to resupply. I'm guessing it didn't set the LBAS state properly?

On Thu, Jan 2, 2020 at 8:41 PM stackhanovets notifications@github.com wrote:

LBAS #1 https://github.com/mrmin123/kcauto/issues/1 has not been resupplied definitely.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/mrmin123/kcauto/issues/426?email_source=notifications&email_token=ABBALUWLUCVNRPNN26X5QZTQ326XDA5CNFSM4J6MKWK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIAISYQ#issuecomment-570460514, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABBALUWHV4FF37FQ2P6MEY3Q326XDANCNFSM4J6MKWKQ .

stackhanovets commented 4 years ago

Man, I don't know how to explain that. The event LBAS squadrons were resupplied completely each time when I inspected it. The 6-5 LBAS resupply handling still fails sometimes. Retrospectively, the event LBAS logic has been implemented after the 2nd May 2016 (sup Iowa) game update and the W6 LBAS has became available after the 5th October 2016 update. Does the latest one's game API utilization contain bugs after the whole time? But KC3Kai successfully detects if any event or non-event LBAS squad requires resupply just after I enter the combat menu...

At least I hope it's not a server-dependent and all game replicas are equal. Could someone confirm a LBAS resupply failure for 6-5?

mrmin123 commented 4 years ago

I'm away from the code right now but could you check the URL of the resupply API call for 6-5? I'm wondering if it's a different call from the event one...

On Wed, Jan 8, 2020 at 3:20 AM stackhanovets notifications@github.com wrote:

Man, I don't know how to explain that. The event LBAS squadrons were resupplied completely each time when I inspected it. The 6-5 LBAS resupply handling still fails sometimes. Retrospectively, the event LBAS logic has been implemented after the 2nd May 2016 (sup Iowa) game update and the W6 LBAS has became available after the 5th October 2016 update. Does the latest one's game API utilization contain bugs after the whole time? But KC3Kai successfully detects if any event or non-event LBAS squad requires resupply just after I enter the combat menu...

At least I hope it's not a server-dependent and all game replicas are equal. Could someone confirm a LBAS resupply failure for 6-5?

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/mrmin123/kcauto/issues/426?email_source=notifications&email_token=ABBALUVG6WDLKNTN6IFO2H3Q4WZIXA5CNFSM4J6MKWK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIMB6BY#issuecomment-572006151, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABBALUTJO5LWZUR25N3DE63Q4WZIXANCNFSM4J6MKWKQ .

perryhuynh / kcauto