search

perryn / blinky

blinky helps you see the light - plug and play set up for build lights
MIT License
67 stars 27 forks source link

fixed usb control message for various colours #12

Open jmpak opened 8 years ago

jmpak commented 8 years ago

The colour values aren't working with the new lights and also the sequence of control message has changed

perryn commented 8 years ago

hi @jmpak

which new lights are these?

jmpak commented 8 years ago

The existing code did not work with the latest batch of Delcom 904006 lights that we ordered. https://www.delcomproducts.com/productdetails.asp?productnum=904006

I had to tweak it to make it work

rastadrian commented 8 years ago

@perryn I can confirm this PR fixes the control sequence and the light values for the new Delcom lights. Thanks @jmpak !

rastadrian commented 8 years ago

Although now that I think about it, maybe this should be yet another device recipe rather than replacing the Delcom Gen2, this might break it for people where this original values were actually working...

perryn commented 8 years ago

Hi @rastadrian and @jmpak

yes exactly, this should be really be a new device recipe. If either of you have the time to put that in a pull request, I'll do a new release

rastadrian commented 8 years ago

@perryn @jmpak I did found an interesting issue though, the light specifications that @jmpak provided are actually for a USB device (Delcom 904006, 904007, 904008) using the exact same vendorId and productId that the light that you have in your project (awesome standards from Delcom) so now we face an interesting situation:

We have two usb devices with the same vendorId, the same productId and with different control transfer sequences.