persephone-tools / persephone

A tool for automatic phoneme transcription
Apache License 2.0
156 stars 26 forks source link

Change class name for RNN-CTC Model #155

Open shuttle1987 opened 6 years ago

shuttle1987 commented 6 years ago

Right now the RNN CTC model in rnn_ctc.py has the class name Model and inherits from model.Model. I find this to be confusing and I propose that we rename the rnn_ctc.Model class and provide the old name via an alias with a deprecation warning until we have confidence we can remove the old name.

oadams commented 6 years ago

As discussed, I agree.