persephone-tools / persephone

A tool for automatic phoneme transcription
Apache License 2.0
154 stars 26 forks source link

Experiment test cases have reference to user path #165

Open shuttle1987 opened 6 years ago

shuttle1987 commented 6 years ago

https://github.com/persephone-tools/persephone/blob/aa695758e675f47e91ef79beb0f470e97f754e6e/persephone/tests/experiments/test_na.py#L260-L273

This test depends on being able to locate a Tensorflow checkpoint file in a local directory. This will fail for other users.

Same with:

https://github.com/persephone-tools/persephone/blob/aa695758e675f47e91ef79beb0f470e97f754e6e/persephone/tests/experiments/test_na.py#L275-L282

And

https://github.com/persephone-tools/persephone/blob/aa695758e675f47e91ef79beb0f470e97f754e6e/persephone/tests/experiments/test_na.py#L284-L292

shuttle1987 commented 5 years ago

Creating a minimal test corpus as per #166 will make this far less of a big deal.