search

persephone-tools / persephone

A tool for automatic phoneme transcription
Apache License 2.0
156 stars 26 forks source link

Remove dependency on sox to split/trim wave files #182

Open shuttle1987 opened 6 years ago

shuttle1987 commented 6 years ago

If desired we could implement a pure python standard library only version of functions like trim_wav_ms by using the wave module https://docs.python.org/3/library/wave.html

oadams commented 6 years ago

That would be good but I agree with your labelling this low-priority. Calling sox for now is fine.

shuttle1987 commented 6 years ago

I guess one thing is that sox may be a whole lot faster depending on how the standard library wave module is implemented. This might be a good first issue for someone to contribute?

oadams commented 6 years ago

Sure, since it's pretty orthogonal to everything else.

shuttle1987 commented 6 years ago

It seems as though Kaldi needs sox anyway

shuttle1987 commented 5 years ago

I think this might be a situation where it makes sense to use this standard library function as a fallback only if sox is not available.