search

persepolisdm / Persepolis-WebExtension

WebExtension integration for Persepolis download manager
http://persepolisdm.github.io
GNU General Public License v3.0
73 stars 9 forks source link

User preference is not stored #24

Open sobuj53 opened 4 years ago

sobuj53 commented 4 years ago

Hi, I use Persepolis download manager web extension in firefox for Linux mint (68.0.1 64-bit) it's very useful to catch download link. However there is only one downside that's, I must explicitly turn on "Interrupt downloads button" in extension every time I open firefox. I think it is an odd behaviour, extension should be able to retain user preference even after closing browser. Expecting your kind review on this. Thank you.

JafarAkhondali commented 4 years ago

@Sobuj53 Hey, Can you tell me your extension version, Persepolis version and operating system? User preferences are stored in browser so what you are reporting is probably a bug.

sobuj53 commented 4 years ago

@JafarAkhondali Jafar Akhondali Thank you for your prompt response. Extension version: 2.2.0 Persepolis version: 3.1.0 Operating system: Linux mint 19.2, Cinnamon (64-bit)

keystroke3 commented 4 years ago

@JafarAkhondali , Has this problem been addressed? I am having the same problem on Manjaro Linux with Firefox 69.0.1 (64-bit). I was hoping it would be solved by now.

sobuj53 commented 4 years ago

No it still persists.

JafarAkhondali commented 4 years ago

@Sobuj53 @keystroke3 I cant reproduce this problem. Can you tell me your Persepolis verison and the extension? Also please provide logs from extension: Go to about:debugging#/runtime/this-firefox, Then press inspect for "Persepolis Download Manager Integration". and go to Console tab.

sobuj53 commented 4 years ago

Hello @JafarAkhondali,

Thank you for your reply. It's actually coming and going now a days. Sometimes it's activating automatically after starting firefox/chrome but most of the time it doesn't. Here is log from my firefox Content Security Policy: Couldn’t parse invalid host 'wasm-eval' Getting Key:pdm-interrupt :: true background.js:438:13 Getting Key:context-menu :: null background.js:438:13 Value Is NuLL:context-menu :: true background.js:441:17 Getting Key:keywords :: background.js:438:13

My Persepolis version is: 3.2.0 Extension Version: 2.2.0 OS: KDE Neon (Ubuntu 18.04 LTS)

Thank you

keystroke3 commented 4 years ago

@JafarAkhondali , Sorry for the late replay. Unlike @Sobuj53 case, mine only comes on when I start my browser. After a few minutes, it goes off. I noticed that if I turned the download interrupt, it would stay on until the next time I reboot my machine. Even if I close down firefox.

My Persepolis version is: 3.2.0 Extension Version: 2.2.0 OS: Manjaro Linux x86_64 Kernel: 5.3.8-1-MANJARO

My console ouput:


Getting Key:pdm-interrupt ::  false background.js:438:13
Getting Key:context-menu ::  null background.js:438:13
Value Is NuLL:context-menu ::  true background.js:441:17
Getting Key:keywords ::  background.js:438:13
Error: Could not establish connection. Receiving end does not exist. 2 h0-main.js:1:192353
Synchronous XMLHttpRequest on the main thread is deprecated because of its detrimental effects to the end user’s experience. For more help http://xhr.spec.whatwg.org/ lpfulllib.js:1:35359
Error: Could not establish connection. Receiving end does not exist. 2 h0-main.js:1:192353
Error: No matching message handler undefined
Unchecked lastError value: Error: Could not establish connection. Receiving end does not exist. webrequest.js:112
Error: Could not establish connection. Receiving end does not exist. 17 h0-main.js:1:192353
Use of nsIFile in content process is deprecated. NetUtil.jsm:253:8
NS_ERROR_FILE_ACCESS_DENIED: Failed to open input source 'file:///' DevToolsUtils.js:678```
Simlock commented 4 years ago

Whenever firefox is restarted, "Interrupt downloads:" is reset to Off. "Toggle enable extension: Ctrl + Shift + U" has no function.

Persepolis: 3.2.0 Firefox Extension: 2.2.0 OS: Windows 10 (64bit) Browser: Firefox 71.0 (64bit)

Could not map contract ID '@mozilla.org/sharepicker;1' to CID {1201d357-8417-4926-a694-e6408fbedcf8} because no implementation of the CID is registered. Getting Key:pdm-interrupt :: false background.js:438:13 Getting Key:context-menu :: null background.js:438:13 Value Is NuLL:context-menu :: true background.js:441:17 Getting Key:keywords :: null background.js:438:13 Value Is NuLL:keywords :: background.js:441:17 Getting Key:pdm-interrupt :: false background.js:438:13 Getting Key:context-menu :: null background.js:438:13 Value Is NuLL:context-menu :: true background.js:441:17 Getting Key:keywords :: null background.js:438:13 Value Is NuLL:keywords :: background.js:441:17 TypeError: Argument 1 of PrecompiledScript.executeInGlobal is not an object. 2 ExtensionContent.jsm:567:25 Getting Key:pdm-interrupt :: true background.js:438:13 Getting Key:context-menu :: null background.js:438:13 Value Is NuLL:context-menu :: true background.js:441:17 Getting Key:keywords :: background.js:438:13

cg00001 commented 3 years ago

Options when I start Firefox: Interrupt downloads: Off Context menu: On I change both and on next Firefox start they are back to the above. Arch Linux. Persepolis extension v2.2.0 Firefox v84.0.1

cg00001 commented 3 years ago

I found out it's not Persepolis' fault. If you set Firefox to clean history it cleans Persepolis' settings too. In my Firefox's Settings for Clearing History when I close Firefox I disable this one. ksnip_20210207-164855

I also use an extension to clear cache etc while I browse, and make sure Plugin data is not enabled to be cleared. https://addons.mozilla.org/en-US/firefox/addon/super-history-cache-cleaner/ ksnip_20210207-165133

You might have noticed in the pics above I don't clear cookies, I keep several sites' cookies so I don't have to log in to them (GitHub included), so this extension deletes the rest and makes it easier to whitelist the ones to keep: https://addons.mozilla.org/en-US/firefox/addon/cookie-autodelete/

cg00001 commented 3 years ago

I found out it's not Persepolis' fault. If you set Firefox to clean history it cleans Persepolis' settings too. In my Firefox's Settings for Clearing History when I close Firefox I disable this one. ksnip_20210207-164855

I also use an extension to clear cache etc while I browse, and make sure Plugin data is not enabled to be cleared. https://addons.mozilla.org/en-US/firefox/addon/super-history-cache-cleaner/ ksnip_20210207-165133

You might have noticed in the pics above I don't clear cookies, I keep several sites' cookies so I don't have to log in to them (GitHub included), so this extension deletes the rest and makes it easier to whitelist the ones to keep: https://addons.mozilla.org/en-US/firefox/addon/cookie-autodelete/

Correction, the Context Menu off preference is only retained. The Interrupt downloads preference on is always set to off when I restart Firefox, even if clearing cache is disabled

cg00001 commented 3 years ago

The best solution for me is just using Ctrl + Shift + U, to toggle. Problem solved.