search

persepolisdm / persepolis

Persepolis Download Manager is a GUI for aria2.
https://persepolisdm.github.io
GNU General Public License v3.0
6.19k stars 651 forks source link

fix firefox issue in windows #728

Closed 7aman closed 3 years ago

7aman commented 4 years ago

This PR adds a persepolis/msghost.py as a middle man to transfer messages from browsers to persepolis. It just affects windows users and has nothing to do with other operating systems.
It also skips sending a response after getting browser messages (for Windows only). It is not a vital part and I will fix it later.
After this PR merged, I will update persepolis-windows-package-build and make a PR to adopt this changes.

alireza-amirsamimi commented 4 years ago

@7aman Hello Sorry for late answer. Thank you very much. Is this ready to use or test?

7aman commented 4 years ago

Hi. I am not sure anymore. I lost my interest and I don't remember all the details about what was I doing.

From reviews above, I remember this PR has still some issue for sending messages to add-on but I doubt that it is a very serious problem. I was just interested to receive add-on messages and launch Persepolis if it was not running. And I think I fixed it.

Also it is related to this issue. It affects the way Persepolis is freezed for windows. https://github.com/persepolisdm/persepolis-windows-package-build/pull/3 I suggest that Persepolis team must provide an easy and clear instruction to run Persepolis from source code on windows platform. It is necessary to have an editable installation to debug and make changes.