search

persepolisdm / persepolis

Persepolis Download Manager is a GUI for aria2.
https://persepolisdm.github.io
GNU General Public License v3.0
6.12k stars 647 forks source link

setup.py is replaced by meson #944

Closed alireza-amirsamimi closed 3 months ago

alireza-amirsamimi commented 3 months ago

You can install persepolis with this commads:

meson setup builddir
cd builddir
meson compile
sudo meson install
alireza-amirsamimi commented 3 months ago

@iFreilicht Please check this pull request

alireza-amirsamimi commented 3 months ago

This is awesome! To test this, I packaged persepolis at 0cd869bfa82a002ae7460806171c2a89d4cf65cc in nixpkgs, and this change greatly reduced the number of patches we had to apply!

See https://github.com/iFreilicht/nixpkgs/commit/45a9c07806938d92c837c2419bffd3dbf535824f if you're interested.

There is still this check that prevents this from neatly building on macOS, though:

if os.path.isdir(notifications_path):

This will always be false on macOS, as you're not setting notifications_path to any value. You could either skip this check, or set the value to an empty string on macOS.

Of course, there will issues at runtime (like notifications not working), but I think for now, it's enough if persepolis builds on macOS, and then we can look into fixing the runtime code.

Thank you, I'll fix that issue.