perses / perses-operator

Apache License 2.0
9 stars 6 forks source link

Missing steps in readme, outdated sample custom resources #12

Closed basti1302 closed 1 week ago

basti1302 commented 2 weeks ago

I think there are a couple of issues in the readme that need to be fixed.

The current first steps recommends to install the custom resource samples. This will of course not work because there was no step installing the CRDS. Error:

error validating "config/samples/kustomization.yaml": error validating data: [apiVersion not set, kind not set]; if you choose to ignore these errors, turn validation off with --validate=false
Error from server (NotFound): error when creating "config/samples/perses.dev_v1alpha1_perses.yaml": the server could not find the requested resource (post perses.perses.dev)
Error from server (NotFound): error when creating "config/samples/perses.dev_v1alpha1_persesdashboard-2.yaml": the server could not find the requested resource (post persesdashboards.perses.dev)
Error from server (NotFound): error when creating "config/samples/perses.dev_v1alpha1_persesdashboard.yaml": the server could not find the requested resource (post persesdashboards.perses.dev)
Error from server (NotFound): error when creating "config/samples/perses.dev_v1alpha1_persesdatasource.yaml": the server could not find the requested resource (post persesdatasources.perses.dev)

I think there should be step make install before this.

Even with CRDs installed, the step kubectl apply -f config/samples/ does not work:

error validating "config/samples/kustomization.yaml": error validating data: [apiVersion not set, kind not set]; if you choose to ignore these errors, turn validation off with --validate=false
Error from server (Invalid): error when creating "config/samples/perses.dev_v1alpha1_perses.yaml": Perses.perses.dev "perses-sample" is invalid: spec.config.deactivate_front: Required value
Error from server (BadRequest): error when creating "config/samples/perses.dev_v1alpha1_persesdashboard-2.yaml": PersesDashboard in version "v1alpha1" cannot be handled as a PersesDashboard: strict decoding error: unknown field "spec.kind", unknown field "spec.metadata", unknown field "spec.spec"
Error from server (BadRequest): error when creating "config/samples/perses.dev_v1alpha1_persesdashboard.yaml": PersesDashboard in version "v1alpha1" cannot be handled as a PersesDashboard: strict decoding error: unknown field "spec.kind", unknown field "spec.metadata", unknown field "spec.spec"
Error from server (BadRequest): error when creating "config/samples/perses.dev_v1alpha1_persesdatasource.yaml": PersesDatasource in version "v1alpha1" cannot be handled as a PersesDatasource: strict decoding error: unknown field "spec.kind", unknown field "spec.metadata", unknown field "spec.spec"

I think the sample custom resources have not been updated in a while and are now outdated.

basti1302 commented 2 weeks ago

Fixed in https://github.com/perses/perses-operator/pull/13