search

perses / perses-operator

Apache License 2.0
10 stars 6 forks source link

fix outdated sample resources, add crd installation to readme #13

Closed basti1302 closed 1 month ago

basti1302 commented 1 month ago

fixes #12

Nexucis commented 1 month ago

Hey @basti1302 thank you for opening this PR !

Sorry for the long time to reply. We put this repository on pause for the moment because we are on other subjects that have a higher priority. So this operator is still working in progress and will stay like that until an unknown date.

So we are definitely looking for contribution to finish this operator ! I am just saying that in case you would like to do it :).

In the meantime @jgbernalp if you have some time to look at the PR, would be cool :).

Also @basti1302 I have ran the CI and it looks like there are some issues. Can you check it ? Thanks

basti1302 commented 1 month ago

Thanks for the update with regard to the state of this repository. Unfortunately I do not have the capacity to contribute significantly to this project.

The CI build issues are unrelated to this PR.

panic: runtime error: invalid memory address or nil pointer dereference [recovered]
    panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0xa[40](https://github.com/perses/perses-operator/actions/runs/11124716530/job/30958820291#step:5:41)aef]

IIRC this is a known bug either in the operator framework or some related dependency. Could be this one, not sure: https://github.com/operator-framework/operator-sdk/issues/6230

Locally I bumped CONTROLLER_TOOLS_VERSIONfromv0.11.1tov0.14.0` to get the build working.

I can create a separate PR, however, that will also regenerate things in config, which is why I left these changes out of this PR.

Nexucis commented 1 month ago

no worries it was just in case Dash0 wanted to see it releases a bit sooner.

Thanks for checking @basti1302

basti1302 commented 1 month ago

I created a PR for updating the controller tools version here: https://github.com/perses/perses-operator/pull/14

jgbernalp commented 1 month ago

LGTM, we can merge when the pipeline is fixed with #14

Nexucis commented 1 month ago

PR #14 has been merged. @basti1302 Can you rebase your PR to see if the build is passing ?

Thanks for your work here, that is super appreciated !

basti1302 commented 1 month ago

PR #14 has been merged. @basti1302 Can you rebase your PR to see if the build is passing ?

Thanks for your work here, that is super appreciated !

Rebased, you're welcome 👍