search

perses / perses-operator

Apache License 2.0
9 stars 6 forks source link

chore: update controller tools from v0.11.0 to v0.14.0 #14

Closed basti1302 closed 1 week ago

basti1302 commented 1 week ago

This should fix the build error that currently happens: panic: runtime error: invalid memory address or nil pointer dereference [recovered] panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0xa[40]

Nexucis commented 1 week ago

for the linter issue, I think it's more related to golanglint-ci itself. WIll merge and adress the issue when I can

basti1302 commented 1 week ago

Thanks for merging.

for the linter issue, I think it's more related to golanglint-ci itself. WIll merge and adress the issue when I can

Right. I think the linting fails because it is executed with Go 1.23, and it might work with an older Go version (1.22 or 1.21). I had similar issues in another project of mine as well; it seems golanglint-ci is picky about the Go version it is executed with. But I am not sure where the Go version for the linting step is set, it seems to come from either - uses: perses/github-actions@v0.1.0 or - uses: ./.github/perses-ci/actions/setup_environment. 🤷