search

persiancal / android-sdk

Android SDK for Persian calendar events
6 stars 4 forks source link

Could we not use ObjectBox for storing data? #15

Open 2hamed opened 4 years ago

2hamed commented 4 years ago

Since this is a SDK and it's better for libraries and SDKs to not depend on third-party package I suggest we move away from ObjectBox to native Sqlite for storing data.

bkhezry commented 4 years ago

@2hamed with using native SQLite we should provide too many codes only to handle CRUD. ObjectBox is so tiny library and useful. In the end, for each solution the .so files are inevitable.

2hamed commented 4 years ago

But sqlite is provided by the OS and no additional .so file is needed. And who knows, it may lead to dependency conflicts if the users are using ObjectBox themselves.

bkhezry commented 4 years ago

@2hamed it's correct. It may be conflicts in creating Singleton instance of BoxStore class. I will be try to prevent from it. As you know, I use some library like retrofit & gson too in this sdk. We can't replace all of them.

2hamed commented 4 years ago

Yes, I understand and I may be able to help developing it further but to do so I need a clear vision of this library is supposed to do and what features are planned. Is there any way we can connect?

bkhezry commented 4 years ago

@2hamed bkhezry at Gmail