persistenceOne / pStake-bugBounty

This repository is to record issues reported for the pStake bug bounty program.
3 stars 2 forks source link

Unnecessary Modal Appears after Metamask Wallet Connection #24

Closed cybertronprime closed 2 years ago

cybertronprime commented 3 years ago

Describe the bug So whenever metamask is connected, we see a small Modal popping up for a few Seconds "stating that there is Network ID Mismatch" which goes away by itself but shouldnt have popped up , as its a successful process.. After reloading the web page, we are needed to connect to wallet again, which is a unnecessary step as we have already connected to the wallet and that should be save some where in the State or Localstorage,

To Reproduce Steps to reproduce the behaviour:

  1. Go to 'Pstake website'
  2. Launch Alpha.pstake.finance
  3. connect Your metamask
  4. After Successful connection, you will see Network ID Mismatch Modal for a few seconds.
  5. It will go away automatically, but should not be there in any case.
  6. Reload the page, now you will need to connect wallet again, and that Modal will appear for a few moments again .

Expected behavior The error should not have occurred , and also we should not need to connect to walled on every reload, as its irritating for any end user,

Screenshots https://drive.google.com/drive/folders/1Qolqx4_-544NzyDuXc9KWYPSosF1I76Q?usp=sharing

Desktop (please complete the following information):

Ethereum address 0xcD988D0DB4B3e7C4A666C8A2fB42E4447E8f11df

Criticality Assessment Please pick one:

Checklist

kombos commented 2 years ago

this has been reproduced.

cybertronprime commented 2 years ago

Reproduced by someone else?

kombos commented 2 years ago

please provide your eth address to receive your bounty

cybertronprime commented 2 years ago

My ethereum Address : 0xcD988D0DB4B3e7C4A666C8A2fB42E4447E8f11df

Thanks

On Thu, Jul 22, 2021 at 11:22 AM kombos @.***> wrote:

please provide your eth address to receive your bounty

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/persistenceOne/pStake-bugBounty/issues/24#issuecomment-884671256, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKGNI5IGZGDPP4VG5HJQRIDTY6WZVANCNFSM47EDTBZQ .

madhursatija commented 2 years ago

Rewards sent: https://etherscan.io/tx/0xe1cf69e04c2400264e8f00636c7014a864430ae96ac96c47c85dd5b8b781c690