persistenceOne / pStake-bugBounty

This repository is to record issues reported for the pStake bug bounty program.
3 stars 2 forks source link

Reconnect to Metamask after page refresh. #28

Open dele22 opened 3 years ago

dele22 commented 3 years ago

Describe the bug Every time I refresh a page a "Connect to a wallet" page appears regardless of whether I have connected before or not.

To Reproduce Steps to reproduce the behaviour:

  1. Go to 'https://alpha.pstake.finance/'
  2. Connect to your Metamask wallet
  3. Click 'refresh page' or press F5
  4. See error

Expected behaviour I would expect (like other DeFi apps) that if you are already connected to your wallet then you dont have to again.

Screenshots Capture

Desktop (please complete the following information):

Ethereum address 0x083bB8D8732A98Efd4F45F41DEDb08f6f67c29a3

Criticality Assessment Please pick one:

Checklist

kombos commented 3 years ago

this is a single page app which follows the onLoad-onRefresh design methodology for connecting and disconnecting wallet. This is not a bug but the way app is designed, not different from banking and financial apps which logs out on refresh. you are not supposed to use refresh button at any point of time in the app, unless expressly instructed in the app itself.