search

persistenceOne / pStake-bugBounty

This repository is to record issues reported for the pStake bug bounty program.
3 stars 2 forks source link

Interface proposals #29

Open rohitkashyapx opened 3 years ago

rohitkashyapx commented 3 years ago

Hi,

We should mention 'staked' next to pATOM. It would help new users to avoid any confusion. Because in most staking wallets, they show a clear distinction for what is staked and what isn't staked. image

We could animate this reload button on clicking, to denote to the user that the refresh has been initiated. image

We should ideally mention the remaining unbonding period here as well, like we do in the Persistence wallet. image image

We can add the APY percentage for the staking of each asset. And if we could also add a switch for auto compounding of daily rewards, that'd be a wonderful feature to add. image

We could add a "Max" button on the Deposit page as well. image

We could add Change wallet and Disconnect options on clicking the wallet button. image

Transactions page: a. Leave space at the left of the first column. The text is too close to the border right now b. We could add green, orange and red dots along with the status for each of confirmed, pending and failed transactions respectively image

Hover text & text box goes below the table. image

Export & Print options not working. image

We should make the menus auto-hide when we hover away - to avoid such overlap of options. image

We should mention the tokens next to the amounts in the transaction table. image

vision2point0 commented 3 years ago
  1. we dont require (staked) text since the staked token itself is self descriptive.
  2. refresh button has a tooltip which would suffice. animation is an alternative choice and not a bug
  3. total unbonding refers to all unsstake positions and not just one. cannot mention the time remaining there.
  4. APY% is being implemented as per a previous suggestion received
  5. wrap funciton should not have a max button since there is no limit to wrapping
  6. This app currently uses the onLoad wallet selection design pattern which does not use a separate connect button. Hence disconnect feature is not relevent in this context. Maybe later if we change the design pattern to connect button based wallet access we could consider.
  7. space has been provided. Also the transations table only provides confirmed transactions so no need for that categorization.
  8. download/print button in txns page is being discontinued.
  9. We will add the unit for each amount.
rohitkashyapx commented 3 years ago

Hi, thanks for the responses. I had a few queries/concerns regarding the responses.

  1. I didn't find a place on the website where it's obvious that pATOM is a staked token.
  2. I never mentioned these suggestions as bugs. The header says "Interface Proposals". And an animation or a message depicting that the refresh button has been pressed and is being worked on - it'd definitely help improve the UX.
  3. It would help the users a lot if we mention the time remaining for the unstaked positions. Refer to the native XPRT wallet: image
  5. Max button is also used by the users sometimes to check the total amount of tokens they can use here. If not, we could add a percentage slider instead.
  7. In that case, according to me, it'd be helpful if we denote the unstaking transaction differently.

Just shared my views from my experience in the design industry. Rest is obviously your call at the end of the day.