persistenceOne / pStake-bugBounty

This repository is to record issues reported for the pStake bug bounty program.
3 stars 2 forks source link

Calculation error in reward distribution of staked atoms. #33

Open arunmadan101 opened 3 years ago

arunmadan101 commented 3 years ago

Describe the bug APR is 15.5%. But I have received 15 pAtoms as rewards for staking 500 sAtoms in one day

To Reproduce Steps to reproduce the behaviour:

  1. Go to https://gala.pstake.finance/
  2. Convert atom to pAtom
  3. Stake pAtom and convert it to sAtom
  4. Wait for one day and check the rewards recieved.

Expected behaviour Per day reward for staking 500 atom must be around 0.21 pAtom

Desktop (please complete the following information):

Ethereum address 0x266039328852fC800486340A589C1B07097eC6C0

Criticality Assessment Please pick one:

Checklist

kombos commented 3 years ago

as mentioned in the documentation, the gala environment is a simulation of the actual cosmos pos environment with the unstaking period, inflation period, epoch interval etc. altered. unstaking period happens to be 21 hours, instead of 21 days. similarly inflation period happens to be 15 days instead of 365 days.. which means 15.5% apr applies not for the whole year but for the span of 15 days.