persistenceOne / pStake-bugBounty

This repository is to record issues reported for the pStake bug bounty program.
3 stars 2 forks source link

pSTAKE don't understand that Keplr can be connected to Ledger #35

Open Antropocosmist opened 3 years ago

Antropocosmist commented 3 years ago

Describe the bug If user create an account in Kepler with Ladger, and after connect pSTAKE to Keplr, then no possibility to sing transaction.
pSTAKE call Keplr Wallet, but pSTAKE don't know that Keplr is connected to Ladger. Because of it, when you click to approve trx in Kepler - Keplr don't call Ledger to sing trx, but just closing. After it. user get: "Transaction is not successful"

To Reproduce Steps to reproduce the behavior:

  1. Go to https://gala.pstake.finance/wrap
  2. Connect MetaMask and Keplr (account in Keplr must be created with Ledger) and approve https://gala.pstake.finance/
  3. Choose to wrap 100 ATOM to 100 pATOM and click on Wrap
  4. In new window click on "Keplr" and new window from Keplr will be opened.
  5. In this new window you can choose trx-fee. Click on "Approve"
  6. Keplr will show for1 second "Waiting for Ledger Confirmation" at the place of approve button, and after window will be closed. Ledger will not ask user to approve trx. pSTAKE will write: "Transaction is not successful"

Expected behaviour I want to wrap test-ATOM to pATOM with https://gala.pstake.finance
I use MetaMask Ropsten TestNet Network and Keplr extension with account, that is created with Ledger.
Cosmos App is turn on on Ledger, and all other transactions with Keplr (also transactions at Osmosis) works perfectly.
After I connect https://gala.pstake.finance to MetaMask and Keplr, try to wrap 100 ATOM to 100 pATOM, Keplr ask me to approve trx, I click on approve, Keplrl shows for 1 second "Waiting for Ledger Confirmation" at the place of approve button, and after window is closed. pSTAKE will write: "Transaction is not successful"

Screenshots

Screenshot from 2021-07-07 01-40-54

Screenshot from 2021-07-07 01-41-07

Screenshot from 2021-07-07 01-41-16

Screenshot from 2021-07-07 01-41-21

Screenshot from 2021-07-07 01-41-33

Screenshot from 2021-07-07 01-41-35

Screenshot from 2021-07-07 01-41-38

Desktop (please complete the following information):

Ethereum address 0x3358Cbf307053264B14f60540d476C1F6Cb28FE5

Criticality Assessment

Checklist

kombos commented 3 years ago

this pertains to the gala environment and not alpha and is not eligible for bug bounty program.

Antropocosmist commented 3 years ago

Yes, I was writing about Gala pSTAKE I just was trying to do my best) Improving of the platform is much more important than any rewards. Hope my issue was helping to improve platform