np.float needs to be changed float due to deprecation in Numpy

perslab / CELLEX

CELLEX (CELL-type EXpression-specificity)

GNU General Public License v3.0

36 stars 9 forks source link

np.float needs to be changed float due to deprecation in Numpy #38

Closed JordanWean closed 3 months ago

JordanWean commented 4 months ago

Cellex uses np.float in the anova.py file which was deprecated in numpy 1.24. Changing np.float to just float seems to fix the issue.

tstannius commented 4 months ago

Hi Jordan

Thanks for your interest.

I do not currently have the time to prioritize addressing such requests and testing how it impacts the output. If anything, I would like to spend time on cellex v2 :-)

Nevertheless, it sounds like you have found a solution so that at least you are not stuck.

Alternatively I would recommend setting up a venv or conda env using the exact versions specified in the requirements.txt.

Best, Tobi

SCQUchenyang commented 3 months ago

Thanks! I met the same error when I "import cellex". Find the script——”site-packages/cellex/preprocessing/anova.py“, and change "np.float=0.00001" to "float=0.00001" is right way.

tstannius commented 3 months ago

Thanks for confirming SCQUchenyang!

I will close this issue for now, as there are solution suggestions in this thread and cellex v2 is higher priority than fixes for v1.

Best, Tobi