search

perslev / CanvasSync

Synchronise modules, assignments and files located on a Canvas by Instructure web server to your local computer.
MIT License
63 stars 28 forks source link

Updated Windows warning and password checks #44

Closed ianakotey closed 2 months ago

ianakotey commented 2 months ago

This PR does the following:

  1. Remove the need for user input on Windows Systems The canvas.entry method requires a Windows User to hit enter after reading a warning. This prevents the tool from being used in automated tasks. A better way to do this might be to detect if the user is running with arguments, and not show the warning in that case, but show the warning when there are no arguments.

  2. Update the password checks The calls to bcrypt's hashpw were not encoding the password as bytes, and hashpw was used to verify password's rather than bcrypt's provided checkpw which is intended for that process. This causes aTypeError crash, as shown below.

Crash-due-to-Password-types

VIXIVIXIV commented 1 month ago

This doesn't seem to work, installing the latest from Github source still gives the error on Windows

ianakotey commented 1 month ago

Hello @VIXIVIXIV, do you mind providing the following information?

  1. A traceback of the current error
  2. The Python version you are currently running
  3. The bcrypt version currently installed (you can use pip freeze to find out)