search

personaelabs / noun-nyms

https://nouns.nymz.xyz
MIT License
14 stars 1 forks source link

[READY FOR REVIEW] add conditional padding based on device width #180

Closed amirgamil closed 1 year ago

amirgamil commented 1 year ago

PR reduces padding on smaller devices to better support threads. Mobile Screenshot 2023-06-10 at 6 48 19 PM Laptop Screenshot 2023-06-10 at 6 49 01 PM

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nym ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 10, 2023 10:52pm
grace-fagan commented 1 year ago

The concept and logic here is good but I refactored the implementation a bit (included in #178 ) to support the new threading logic and match how we are handling responsive styling. We have an isMobile flag in the app context based on device width and use tailwind's md breakpoint class.

amirgamil commented 1 year ago

@grace-fagan cool we can wait until that merges then I can update my implementation then

amirgamil commented 1 year ago

Closed because done in #178