personaelabs / noun-nyms

https://nouns.nymz.xyz
MIT License
14 stars 1 forks source link

Reduce bundle size #187

Closed DanTehrani closed 1 year ago

DanTehrani commented 1 year ago

Unfortunately, I didn't see any improvements from removing large dependencies. So the cause is still unknown, but we have a little less than 4s initial execution time (from my region Europe) by allocating max memory to the function.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nym ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2023 4:01pm
cha0sg0d commented 1 year ago

@DanTehrani how are you calculating the 4s cold start time?

DanTehrani commented 1 year ago

@DanTehrani how are you calculating the 4s cold start time?

@cha0sg0d To be precise the execution time of the initial invocation is ~=4s. You can see it in the logs

Screenshot 2023-06-15 at 20 03 06
cha0sg0d commented 1 year ago

Adding some more info comparing this branch with nym dev

https://dev.nymz.xyz

CleanShot 2023-06-15 at 11 30 19@2x

this preview branch

CleanShot 2023-06-15 at 11 30 42@2x
cha0sg0d commented 1 year ago

@DanTehrani if this PR doesn't improve the performance. perhaps we don't need to merge it? Or worthwhile anyway, wdyt?

DanTehrani commented 1 year ago

@DanTehrani if this PR doesn't improve the performance. perhaps we don't need to merge it? Or worthwhile anyway, wdyt?

@cha0sg0d I think reducing the dependency size is good since we can get faster CI/dev env. And it's good to know that the dep size is not ridiculously large to identify the root cause when we further debug the slow init innovations!