personaelabs / spartan-ecdsa

The fastest in-browser verification of ECDSA signatures in ZK, using Spartan on the secq256k1 curve
198 stars 28 forks source link

membership verifier in ts lib #15

Closed lsankar4033 closed 1 year ago

lsankar4033 commented 1 year ago

For https://github.com/personaelabs/spartan-ecdsa/issues/8

lsankar4033 commented 1 year ago

@DanTehrani am continuing to investigate, but in case you have a spare minute, does anything obvious look wrong in the way I've structured membership_verifier here?

verification is failing for me locally (i.e. in membership_nizk test)

DanTehrani commented 1 year ago

@lsankar4033 will check it out now!

DanTehrani commented 1 year ago

@lsankar4033 It was just the prover returning the public input incorrectly (was missing the root), my bad. Pushed the fix f41768f14a7ce7a3e998a0b008ee55a824fe1577!

lsankar4033 commented 1 year ago

wow that was fast 🐐

lsankar4033 commented 1 year ago

still failing, but I'll dig deeper

DanTehrani commented 1 year ago

@lsankar4033 Hmm in my env membership_nizk.test.ts passes.

Maybe run these scripts to compile the circuits to the latest ones?

DanTehrani commented 1 year ago

(forgot to add that instruction to the readme, will add it if the above works)

lsankar4033 commented 1 year ago

@DanTehrani ready for review/merge!