Only create SVG once and update child elements as needed

personality-insights / sunburst-chart

A visualization for IBM Watson Personality Insights service output.

https://personality-insights.github.io/sunburst-chart/

Apache License 2.0

43 stars 37 forks source link

Only create SVG once and update child elements as needed #37

Closed soumak77 closed 6 years ago

soumak77 commented 6 years ago

Refactor logic for setting the text so that it is contained within the widget. This enables both v3 and v4 to use the same method for changing the text.

Also made updates to save references to path and text elements so that they don't need to be removed and readded with each render.

Fixes https://github.com/personality-insights/sunburst-chart/issues/32 and #33

soumak77 commented 6 years ago

@germanattanasio thanks for merging. I'm working on some updates right now. Trying to get D3 version 4 working. At the minimum, I'm refactoring all the common code between v3 and v4 so that if I can't figure this out, it'll be cleaned up for someone else to quickly get up to speed.