search

personalizedrefrigerator / joplin-plugin-extra-editor-settings

Allows confiuring serveral built-in CodeMirror 6 settings not exposed through Joplin's GUI.
MIT License
4 stars 0 forks source link

Settings not retained on restart of Joplin #1

Closed jahoyne closed 4 months ago

jahoyne commented 6 months ago

Everything works as expected, put the settings are not preserved after a restart of Joplin.

Once the settings are re-entered it works as expected.

Joplin Version and Plugins in use Joplin 3.0.6 (prod, linux) Client ID: 615c7880d02145c5a89371d6264bdcb9 Sync Version: 3 Profile Version: 47 Keychain Supported: No Revision: 18b9f5c Admonition markdown extension: 1.1.0 Backup: 1.4.1 CodeMirror 6 settings: 1.0.0 CodeMirror 6 snippets: 0.0.5 Conflict Resolution: 1.2.3 Copy Code Blocks: 1.1.0 Copy Universal Web Link: 0.1.0 Create and go to #tags and @notebooks: 1.3.7 Draw.io: 2.2.0 Embed Search: 2.0.0 Enhancement: 1.2.1 History Panel: 1.0.2 Home Note: 2.0.0 Hotfolder: 1.1.1 Inline tags: 1.3.0 Insert Date: 1.0.1 joplin-note-email: 1.0.5 joplin-plugin-TimelineRender: 1.0.2 Kminder Mindmap Joplin Plugin: 0.8.6 Markdown Prettier: 0.1.0 Markdown Table: Colorize: 1.2.0 Markdown Table: Sortable: 1.2.2 Markmap: 1.6.0 Menu items, Shortcuts, Toolbar icons: 1.1.0 Note Statistics: 1.0.4 Note Tabs: 1.4.0 Outline: 1.5.13 Paste Special: 1.1.2 Persistent Editor Layout: 2.2.0 PlantUML2: 1.11.0 Quick Links: 1.3.2 Quick Move: 1.1.0 Rich Markdown: 0.15.0 Spoilers: 1.0.6 Tagging: 1.0.3 Templates: 2.4.0 turnToChart: 1.9.3 VS-Code Style Note Search: 0.0.1

Thanks, for all your great work.

personalizedrefrigerator commented 6 months ago

Thank you for letting me know!

This plugin stores settings in settings.json in the profile directory (rather than in Joplin's database). This is done using the plugin API's SettingStorageType.File option.

I think I've had this happen 1-2 times, but not consistently. I suspect that a bug exists in loading/saving settings to the JSON file.

personalizedrefrigerator commented 6 months ago

Upstream issue: https://github.com/laurent22/joplin/issues/10381

personalizedrefrigerator commented 5 months ago

Upstream pull request: https://github.com/laurent22/joplin/pull/10458

personalizedrefrigerator commented 4 months ago

As in the CodeMirror 6 snippets plugin, this should be fixed in Joplin v3.0.9.

personalizedrefrigerator commented 4 months ago

Joplin 3.0.x is now stable! I'm closing this as resolved.