personalizedrefrigerator / joplin-plugin-revealjs-slides

Present Joplin notes as slide decks.
MIT License
11 stars 1 forks source link

Conflicting with "Automatic Backlinks to note" plugin #2

Closed 235 closed 4 months ago

235 commented 9 months ago

Hi, amazing work! Heads-up, I found though it appears to conflict with "Automatic Backlinks to note" plugin. When it's turned on, I'm either getting a wrong note to be rendered (likely linked), or just empty note rendered. I suspect that's because the backlinks plugin is dynamically trying to change all the views, but not sure how to triage this issue. Would appreciate a suggestion!

personalizedrefrigerator commented 9 months ago

Thank you for reporting this!

Looking at the Automatic backlinks plugin's content script, I suspect that this issue is caused by the Automatic Backlinks plugin's lack of a </style> in its <style> tag.

Without a closing </style>, the code added by the RevealJS plugin to get the note content is considered part of the previous <style> tag and thus not loaded.

As such, this pull request on the Backlinks repository may also fix the issue.

235 commented 9 months ago

Thank you for looking into this! Waiting for that patch to land to get backlinks back.

personalizedrefrigerator commented 7 months ago

This may be fixed in version 0.8.2 — the Reveal.js plugin now gets rendered HTML from the note viewer in a slightly different way.

personalizedrefrigerator commented 4 months ago

I'm closing this, as I think this is fixed.

If this is still an issue, please let me know and I can re-open this.