personalizedrefrigerator / js-draw

Draw pictures using a pen, touchscreen, or mouse! JS-draw is a freehand drawing library for JavaScript and TypeScript.
https://personalizedrefrigerator.github.io/js-draw/typedoc/
MIT License
79 stars 8 forks source link

mouse click for selection does not make much sense #29

Closed Wladefant closed 11 months ago

Wladefant commented 11 months ago

Everything in the toolbar was clear or almost clear for me, except the mouse

I was not sure what it was, clicked on it and through trying understood that it was the selction tool. The desiign convention for selection is this dotted line and i would suggest we use it. SmartSelect_20230919_001622_Samsung Notes

personalizedrefrigerator commented 11 months ago

Thank you for the feedback!

js-draw's icons are currently based on the Material Icon Pack from Google. Here are two similar icons from that pack:

select: Icon: Dashed rectangle

gesture_select: Icon: Pointing hand over dashed rectangle

I chose rectangular selection icons because js-draw doesn't support lasso selection (though it is something I would like to eventually implement).

Note that Joplin is sponsoring development of js-draw and has @MartaLC reviewing and creating a design for the app UI. The design can be found here. Feel free to leave design-related comments there as well!

I've added a link to this issue to the Figma file.

Wladefant commented 11 months ago

For future reference I will leave the link for the lasso select HERE. Lasso select is definitely a needed feature even though not priority number one.

These icons are for sure much better. The first icon would match the style perfectly

personalizedrefrigerator commented 11 months ago

Resolved in a8b3b5644355a77bfd61ee8e4142d05d6e355268

Wladefant commented 11 months ago

Nice @personalizedrefrigerator which one did you choose?

personalizedrefrigerator commented 11 months ago

I chose

select: Icon: Dashed rectangle

I've also received some feedback about how Exit and Save behave (that "Save" shouldn't close the editor, see the Figma file). I plan to build/release a new Android version after making this Save/Exit change.

Wladefant commented 11 months ago

chose\n\nselect:\n

Yes that is the one I am talking about