Add RoGuE support for ADA

personalrobotics / ada

Software for ADA, the Assistive Dextrous Arm developed by the Personal Robotics Lab at CMU.

1 stars 9 forks source link

Closed rachelholladay closed 8 years ago

rachelholladay commented 8 years ago

Add in RoGuE (Robot Gesture Engine)
Add action lib including RoGuE and grasping
Cleans up action lib and tsr lib for environment locking (standardized to match herbpy)
Fix some broken tsrs

mkoval commented 8 years ago

@Stefanos19 You should review this pull request since you're the maintainer of AdaPy. :smile:

Stefanos19 commented 8 years ago

@rachelholladay Could you please update the PR with the changes in PR #50 and https://github.com/personalrobotics/prpy/pull/254?

rachelholladay commented 8 years ago

@Stefanos19 I adjusted for PR #50 and when personalrobotics/prpy#254 gets merged into master, i'll test my code again with it and adjust accordingly.

mkoval commented 8 years ago

@Stefanos19 Could you review this now that @rachelholladay has made those changes?

Stefanos19 commented 8 years ago

Should we wait for the CloseHand() issue to be resolved? (personalrobotics/prpy#254) Otherwise, it looks good to me!

rachelholladay commented 8 years ago

@Stefanos19 Updated to fix the finger limit issue and use the closehand commands instead of the move hand ones.

rachelholladay commented 8 years ago

@mkoval Excellent points. They have been fixed.