personalrobotics / ada_feeding

Robot-assisted feeding demos and projects for the ADA robot
4 stars 4 forks source link

Move the head and `wheelchair_collision` in `ada_planning_scene.py` #165

Closed amalnanavati closed 6 months ago

amalnanavati commented 6 months ago

Description

In service of #144 . Earlier, the MoveToMouth tree was moving the head and scaling the wheelchair collision object based on the results of face detection. However, this has two downsides:

  1. We have to pass in planning scene information and mesh assets into MoveToMouth tree.
  2. It can only change the planning scene at pre-defined parts of the behavior tree.

This PR addresses that by moving the planning scene update logic to ada_planning_scene.py; now, all planning scene updates are handled by that one node. Further, this lays the groundwork for not having the robot lock in the user's head position before MoveToMouth, because if the web app does not toggle face detection off, then the mouth frame will automatically adjust as the robot arm moves, resulting in the arm adjusting to the user's head position.

Testing procedure

Before opening a pull request

Before Merging