personalrobotics / aikido

Artificial Intelligence for Kinematics, Dynamics, and Optimization
https://personalrobotics.github.io/aikido/
BSD 3-Clause "New" or "Revised" License
213 stars 30 forks source link

Set the interactive marker viewer to autoupdate by default. #589

Closed aditya-vk closed 2 years ago

aditya-vk commented 3 years ago

The user is currently required to do the following:

  aikido::rviz::InteractiveMarkerViewer viewer(topicName, frameName, world);
  viewer.setAutoUpdate(true);

The default expectation on introducing a viewer is to see the frames being updated in simulation. The user shouldn't need to explicitly set updates to be true.


Before creating a pull request

Before merging a pull request

codecov[bot] commented 2 years ago

Codecov Report

Merging #589 (efaebf4) into master (62dfb15) will increase coverage by 0.77%. The diff coverage is 76.68%.

@@            Coverage Diff             @@
##           master     #589      +/-   ##
==========================================
+ Coverage   75.59%   76.37%   +0.77%     
==========================================
  Files         243      200      -43     
  Lines        5856     7030    +1174     
==========================================
+ Hits         4427     5369     +942     
- Misses       1429     1661     +232     
Impacted Files Coverage Δ
include/aikido/common/BSpline.hpp 100.00% <ø> (ø)
include/aikido/common/RNG.hpp 100.00% <ø> (ø)
include/aikido/common/Spline.hpp 100.00% <ø> (ø)
...clude/aikido/common/detail/ExecutorThread-impl.hpp 100.00% <ø> (ø)
include/aikido/common/detail/Spline-impl.hpp 96.96% <ø> (+0.22%) :arrow_up:
include/aikido/common/detail/algorithm-impl.hpp 100.00% <ø> (ø)
...lude/aikido/common/detail/metaprogramming-impl.hpp 80.00% <ø> (ø)
include/aikido/common/detail/pair-impl.hpp 100.00% <ø> (ø)
include/aikido/constraint/Differentiable.hpp 100.00% <ø> (ø)
...clude/aikido/constraint/DifferentiableSubspace.hpp 100.00% <ø> (ø)
... and 253 more