personalrobotics / aikido

Artificial Intelligence for Kinematics, Dynamics, and Optimization
https://personalrobotics.github.io/aikido/
BSD 3-Clause "New" or "Revised" License
213 stars 30 forks source link

Clean up ConcreteRobot plan methods to take MetaSkeletonStateSpace::State*. #591

Open sniyaz opened 3 years ago

sniyaz commented 3 years ago

During the review of https://github.com/personalrobotics/aikido/pull/588, we realized that (for some reason) these methods take StateSpace::State* instead of MetaSkeletonStateSpace::State*. Since we're working with ConcreteRobot we must be working with MetaSkeletonStateSpace::State* (unless the user is doing something very stupid).

We should fix this at some point, potentially during @aditya-vk's refactor of the Robot classes.